fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] thesmallstar commented on a change in pull request #906: FINERACT-942 Remove use of printStackTrace and added checkstyle
Date Thu, 21 May 2020 15:24:52 GMT

thesmallstar commented on a change in pull request #906:
URL: https://github.com/apache/fineract/pull/906#discussion_r428725673



##########
File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/calendar/service/CalendarUtils.java
##########
@@ -114,7 +116,7 @@ private static Date convertToiCal4JCompatibleDate(final LocalDate inputDate)
{
         try {
             formattedDate = new Date(seedDateStr, "yyyy-MM-dd");
         } catch (final ParseException e) {
-            e.printStackTrace();
+            LOG.error("{}",e.getMessage());

Review comment:
       It does throw a parse exception, a possible explanation is the string received might
be complete gibberish and could not be parsed as a date?
   ![image](https://user-images.githubusercontent.com/42006277/82574789-3fc4e980-9ba5-11ea-8822-11df0633975a.png)
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message