fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] maektwain commented on pull request #915: FINERACT-986: Update spotbugs to v4.2.0
Date Thu, 21 May 2020 07:06:38 GMT

maektwain commented on pull request #915:
URL: https://github.com/apache/fineract/pull/915#issuecomment-631923153


   The method is updating the values, in the savings account charge now the null value was
there to initialise it , might be the case that it was checking for null values somewhere
else while applying the charges and then based on that computing from zero. 
   
   This could be interesting to note that we can start to remove all the null values where
it should be a bigDecimal as zero functionally .
   
   What are your thoughts ?
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message