fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] awasum commented on a change in pull request #915: FINERACT-986: Update spotbugs to v4.2.0
Date Wed, 20 May 2020 14:38:17 GMT

awasum commented on a change in pull request #915:
URL: https://github.com/apache/fineract/pull/915#discussion_r428064991



##########
File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccountCharge.java
##########
@@ -474,7 +475,7 @@ public void update(final BigDecimal amount, final LocalDate dueDate, final
Month
                 break;
                 case PERCENT_OF_AMOUNT:
                     this.percentage = newValue;
-                    this.amountPercentageAppliedTo = null;
+                    this.amountPercentageAppliedTo = BigDecimal.ZERO;

Review comment:
       Hoping this is not checked for null somewhere in the code base?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message