fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From awa...@apache.org
Subject [fineract] branch develop updated: Remove direct explicit Guava dependency (FINERACT-963) (#913)
Date Wed, 20 May 2020 09:00:37 GMT
This is an automated email from the ASF dual-hosted git repository.

awasum pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git


The following commit(s) were added to refs/heads/develop by this push:
     new e8276f0  Remove direct explicit Guava dependency (FINERACT-963) (#913)
e8276f0 is described below

commit e8276f0aea1dff89fc656acb97b11be131f23f19
Author: Michael Vorburger ⛑️ <mike@vorburger.ch>
AuthorDate: Wed May 20 11:00:29 2020 +0200

    Remove direct explicit Guava dependency (FINERACT-963) (#913)
    
    We *ARE* using Guava, but, unless we have a real need for a more recent
    specific version, it seems "safer" (and less hassle to maintain bumping)
    just using whatever version we transitively inherit from other libraries
    we use that themselves depend on Guava (currently Swagger, Mustache and
    activemq-broker).
    
    Currently that "whatever version" is a 28.2 (we used 28.1 before).
    
    This removes two fairly different kinds of Guava dependencies we have:
    One for run-time (above), and one for build time which seems to have
    been added due to some SpotBugs related issue (but it now works without
    that, so that must have been some issue in SpotBugs that meanwhile go
    fixed in the recent versions).
---
 fineract-provider/build.gradle        | 4 ----
 fineract-provider/dependencies.gradle | 1 -
 2 files changed, 5 deletions(-)

diff --git a/fineract-provider/build.gradle b/fineract-provider/build.gradle
index 5689df0..511d707 100644
--- a/fineract-provider/build.gradle
+++ b/fineract-provider/build.gradle
@@ -45,9 +45,6 @@ buildscript {
         classpath 'com.radcortez.gradle:openjpa-gradle-plugin:3.1.0'
         classpath 'gradle.plugin.org.nosphere.apache:creadur-rat-gradle:0.3.1'
         classpath "gradle.plugin.com.github.spotbugs.snom:spotbugs-gradle-plugin:4.0.8"
-        // Use Guava version 23+ as a workaround to spotbug intergration.
-        // See: https://github.com/spotbugs/spotbugs-gradle-plugin/issues/128#issuecomment-535864882
-        classpath 'com.google.guava:guava:28.1-jre'
         classpath "gradle.plugin.com.github.andygoossens:gradle-modernizer-plugin:1.3.0"
         classpath "gradle.plugin.com.gorylenko.gradle-git-properties:gradle-git-properties:2.2.2"
     }
@@ -87,7 +84,6 @@ dependencyManagement {
         dependency 'com.squareup.okhttp:okhttp:2.0.0'
         dependency 'com.squareup.okhttp:okhttp-urlconnection:2.0.0'
         dependency 'com.google.code.gson:gson:+'
-        dependency 'com.google.guava:guava:28.1-jre'
         dependency 'org.apache.commons:commons-email:1.5'
         dependency 'org.apache.commons:commons-io:+'
         dependency 'org.drizzle.jdbc:drizzle-jdbc:1.4'
diff --git a/fineract-provider/dependencies.gradle b/fineract-provider/dependencies.gradle
index 7bc6364..4debce9 100644
--- a/fineract-provider/dependencies.gradle
+++ b/fineract-provider/dependencies.gradle
@@ -44,7 +44,6 @@ dependencies {
             'com.sun.jersey.contribs:jersey-multipart',
 
             'joda-time:joda-time',
-            'com.google.guava:guava',
             'com.google.code.gson:gson',
             'com.sun.jersey:jersey-core',
             'com.squareup.retrofit:retrofit',


Mime
View raw message