fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #830: FINERACT-822 enable and enforce Error Prone
Date Tue, 19 May 2020 23:01:00 GMT

vorburger commented on a change in pull request #830:
URL: https://github.com/apache/fineract/pull/830#discussion_r427647609



##########
File path: fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/StaffTest.java
##########
@@ -183,13 +185,15 @@ public void testStaffUpdate() {
         Assert.assertEquals(mobileNo, changes.get("mobileNo"));
     }
 
+    @SuppressWarnings("JUnit4TestNotRun")
     public void testStaffUpdateLongExternalIdError() {
         final HashMap<String, Object> map = new HashMap<>();
         map.put("externalId", Utils.randomStringGenerator("EXT", 98));
 
         StaffHelper.updateStaff(requestSpec, responseSpecForValidationError, 1, map);
     }

Review comment:
       @percyashu I suppose someone just "forgot" to add `@Test` ? 
   
   What I suggest you do is do add `@Test` for all these cases (instead of `@SuppressWarnings("JUnit4TestNotRun")`),
and try running them. If they fail, slap an `@Ignore` on those that do fail - and then subsequently
but in a later separate PR see if you can fix them (or someone else can do that, as part of
future work to review all ignored tests). Sounds like a plan?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message