fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on pull request #894: bump json-path from 0.9.1 to 2.4.0 (FINERACT-964)
Date Tue, 19 May 2020 22:56:27 GMT

vorburger commented on pull request #894:
URL: https://github.com/apache/fineract/pull/894#issuecomment-631130229


   > Yes. One test.
   
   which one? I just ran https://github.com/apache/fineract#code-coverage-reports, and found
that `ResolutionHelper` basically has 0% unit test coverage (except for its constructor).
We therefore can't really know if these change break that class, or everything still works
as before. There may be 2 separate issues - FINERACT-985 ITs are not covered by Jacoco + `ResolutionHelper`
may or may not be covered by any IT (I don't know).
   
   I'll just merge his anyway, but it's theoretically possible that it break some batch related
feature.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message