fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #887: FINERACT-830: Configuring Dockerfile to use Google Distroless base image
Date Tue, 19 May 2020 21:39:05 GMT

vorburger commented on a change in pull request #887:
URL: https://github.com/apache/fineract/pull/887#discussion_r427615823



##########
File path: Dockerfile
##########
@@ -32,30 +32,11 @@ COPY *LICENSE* fineract/
 COPY *NOTICE* fineract/
 
 WORKDIR fineract
-# RUN find .
-RUN ./gradlew clean -x rat -x test war
+RUN ./gradlew clean -x rat -x test bootJar
 
 # =========================================
 
-FROM bitnami/tomcat:9.0 as fineract
+FROM gcr.io/distroless/java:11 as fineract
 
-USER root
-RUN apt-get update -qq && apt-get install -y wget
-
-COPY --from=builder /fineract/build/libs/fineract-provider.war /opt/bitnami/tomcat/webapps
-
-RUN keytool -genkey -keyalg RSA -alias tomcat -keystore /opt/bitnami/tomcat/tomcat.keystore
-keypass xyz123 -storepass xyz123 -noprompt -dname "CN=Fineract, OU=Fineract, O=Fineract,
L=Unknown, ST=Unknown, C=Unknown"
-COPY ./docker/server.xml /opt/bitnami/tomcat/conf
-RUN chmod 664 /opt/bitnami/tomcat/conf/server.xml
-
-WORKDIR /opt/bitnami/tomcat/lib
-# org.drizzle.jdbc.DrizzleDriver is used by default for both the all tenants and demo tenant
DB DataSource
-RUN wget https://repo1.maven.org/maven2/org/drizzle/jdbc/drizzle-jdbc/1.4/drizzle-jdbc-1.4.jar
-
-# https://issues.apache.org/jira/browse/LEGAL-462
-# https://issues.apache.org/jira/browse/FINERACT-762
-# We include an alternative JDBC driver (which is faster, but not allowed to be default in
Apache distribution)
-# allowing implementations to switch the driver used by changing start-up parameters (for
both tenants and each tenant DB)
-# The commented out lines in the docker-compose.yml illustrate how to do this.
-# To be sure that this instead of Drizlle is used, comment out wget above.
-RUN wget https://repo1.maven.org/maven2/mysql/mysql-connector-java/8.0.19/mysql-connector-java-8.0.19.jar

Review comment:
       @ptuomola thanks! I'd love to manually test deploy this on https://www.fineract.dev
before I merge it - I'll try to do that in the coming days, and assuming that it "just works"
(which I expect that it will, just to be extra careful...), I'll merge it; hope that's OK.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message