fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on pull request #906: [WIP] FINERACT-942 Remove use of printStackTrace and added checkstyle
Date Tue, 19 May 2020 07:21:53 GMT

vorburger commented on pull request #906:
URL: https://github.com/apache/fineract/pull/906#issuecomment-630635248


   @thesmallstar no in non-test it depends.. definitely never printStackTrace() but either
catch(SomeException e) { LOG.error("explanation", e) -OR- (re, "chain") throw NewEception("Details",
e) - but typically never BOTH log and re-throw but only either-or. HTH?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message