fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #906: [WIP] FINERACT-942 Remove use of printStackTrace and added checkstyle
Date Mon, 18 May 2020 07:58:05 GMT

vorburger commented on a change in pull request #906:
URL: https://github.com/apache/fineract/pull/906#discussion_r426435287



##########
File path: fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/AccountingScenarioIntegrationTest.java
##########
@@ -587,11 +587,8 @@ public void checkPeriodicAccrualAccountingFlow() {
         this.journalEntryHelper.checkJournalEntryForAssetAccount(assetAccount, this.EXPECTED_DISBURSAL_DATE,
assetAccountInitialEntry);
 
         final String jobName = "Add Accrual Transactions";
-        try {
-            this.schedulerJobHelper.executeJob(jobName);
-        } catch (InterruptedException e) {
-            e.printStackTrace();

Review comment:
       No, in a test, exceptions typically should not be logged but just "fall through" (propagate,
with 'testXYZ() throws SomeException, Another # Exception...'), so that the test fails, if
the exception happens. PS: We need to write this and more like this up into Logging Guidelines,
e.g. on the README. Do you want to make a start with that in this PR?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message