fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] awasum commented on pull request #832: remove (useless) SenderTest + mockrunner-jms/nekohtml (FINERACT-938)
Date Sun, 17 May 2020 06:55:08 GMT

awasum commented on pull request #832:
URL: https://github.com/apache/fineract/pull/832#issuecomment-629752568


   Please, merge it now. I just wanted someone familiar with the notification
   feature to look at it. But we can't keep waiting for that forever. So merge
   this ASAP. Thanks and sorry for holding this  that's precious time but it
   was for a good reason.
   
   On Sun, May 17, 2020, 01:44 Michael Vorburger ⛑️ <notifications@github.com>
   wrote:
   
   > I've just rebased this and resolved conflicts. @awasum
   > <https://github.com/awasum> given that we haven't heard back from @Anh3h
   > <https://github.com/Anh3h> within 1 week, and that @ptuomola
   > <https://github.com/ptuomola> expresses support for *"great if we can get
   > rid of Mockrunner with its awful dependency tree"* and my explanations
   > about the value of this test, would you have any strong objections to
   > merging this? It's a simplification of our dependencies which we will only
   > be grateful for in the future, at the loss of a IMHO useless test.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/fineract/pull/832#issuecomment-629725714>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/ADWPAYHRUSWSRICVXBJ43M3RR4XN3ANCNFSM4M4DMJLA>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message