fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From awa...@apache.org
Subject [fineract] branch develop updated: make javac fail, not just warn, for (Xlint) unchecked (FINERACT-959) (#859)
Date Fri, 15 May 2020 20:31:30 GMT
This is an automated email from the ASF dual-hosted git repository.

awasum pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git


The following commit(s) were added to refs/heads/develop by this push:
     new 0eee0ff  make javac fail, not just warn, for (Xlint) unchecked (FINERACT-959) (#859)
0eee0ff is described below

commit 0eee0ff7754dc931527af98be616f43aecc40c9a
Author: Michael Vorburger ⛑️ <mike@vorburger.ch>
AuthorDate: Fri May 15 22:31:16 2020 +0200

    make javac fail, not just warn, for (Xlint) unchecked (FINERACT-959) (#859)
    
    This is just a first step - we should aim for -Xlint:all! ;)
---
 fineract-provider/build.gradle                                         | 2 +-
 .../java/org/apache/fineract/integrationtests/SchedulerJobsTest.java   | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/fineract-provider/build.gradle b/fineract-provider/build.gradle
index 18cc67a..5bcba34 100644
--- a/fineract-provider/build.gradle
+++ b/fineract-provider/build.gradle
@@ -284,7 +284,7 @@ configurations {
 }
 
 tasks.withType(JavaCompile) {
-    options.compilerArgs << '-Xlint:unchecked'
+    options.compilerArgs += ["-Xlint:unchecked", "-Werror"] // TODO FINERACT-959 (gradually)
enable -Xlint:all (see "javac -help -X")
     options.deprecation = true
 }
 
diff --git a/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/SchedulerJobsTest.java
b/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/SchedulerJobsTest.java
index 623cfd8..d00e03a 100644
--- a/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/SchedulerJobsTest.java
+++ b/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/SchedulerJobsTest.java
@@ -108,7 +108,7 @@ public class SchedulerJobsTest {
             Map<String, Object> schedulerJob = schedulerJobHelper.getSchedulerJobById(jobId);
 
             // Executing Scheduler Job
-            schedulerJobHelper.runSchedulerJob(requestSpec, jobId.toString());
+            SchedulerJobHelper.runSchedulerJob(requestSpec, jobId.toString());
 
             // Retrieving Scheduler Job by ID
             schedulerJob = schedulerJobHelper.getSchedulerJobById(jobId);
@@ -121,6 +121,7 @@ public class SchedulerJobsTest {
                 assertNotNull(schedulerJob);
                 System.out.println("Job " + jobId +" is Still Running");
             }
+            @SuppressWarnings({ "unchecked", "rawtypes" })
             List<Map> jobHistoryData = schedulerJobHelper.getSchedulerJobHistory(jobId);
 
             // Verifying the Status of the Recently executed Scheduler Job


Mime
View raw message