fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] thesmallstar commented on a change in pull request #891: [WIP] Logging checkstyle (Remove use of System.out)
Date Fri, 15 May 2020 19:39:02 GMT

thesmallstar commented on a change in pull request #891:
URL: https://github.com/apache/fineract/pull/891#discussion_r426009809



##########
File path: fineract-provider/src/test/java/org/apache/fineract/notification/Listener.java
##########
@@ -29,6 +29,6 @@
     @Override
     public void onMessage(Message message, Session session) throws JMSException {
         TextMessage msg = (TextMessage) message;
-        System.out.println("Received: " + msg.getText());
+        LOG.debug("Received: " + msg.getText());

Review comment:
       Yes, no System.out  in a non-test folder.
   Replacing all of them with LOG.info :)
   
   
   -thanks 
   Manthan
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message