fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #891: [WIP] Logging checkstyle (Remove use of System.out)
Date Fri, 15 May 2020 17:46:22 GMT

vorburger commented on a change in pull request #891:
URL: https://github.com/apache/fineract/pull/891#discussion_r425955126



##########
File path: fineract-provider/src/test/java/org/apache/fineract/notification/Listener.java
##########
@@ -29,6 +29,6 @@
     @Override
     public void onMessage(Message message, Session session) throws JMSException {
         TextMessage msg = (TextMessage) message;
-        System.out.println("Received: " + msg.getText());
+        LOG.debug("Received: " + msg.getText());

Review comment:
       it's probably OK, and likely better/clearer, to simply always use `LOG.info()` instead
of `debug()` to replace `System.out.println()` in tests. In "real" (non-test) code, it's...
not always super obvious which level is right. But, hopefully, you won't find any `System.out.println()`
in non-test code?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message