fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] xurror edited a comment on pull request #857: [WIP] MySQL v8(FINERACT-897)
Date Sun, 10 May 2020 14:11:36 GMT

xurror edited a comment on pull request #857:
URL: https://github.com/apache/fineract/pull/857#issuecomment-626333747


   > I would prefer to see the Flyway upgrade raised a separate PR with ref. to FINERACT-810.
Make FINERACT-810 a blocker for FINERACT-897 if that is the case (I'm assuming that you have
found that it is).
   
   Not a problem. I can chop that change off this PR and raise a different PR for it.
   
   > As for reviewing the (massive, wow, how did you do that, hats off!) SQL diff in this
PR, I'm not the most qualified - I'm hoping other parties interested in MySQL would chime
in to review this better than I could.
   
   It was not much of a struggle. All the scripts are basically thesame as before. I just
updated some deprecated features such int(10).. etc. Most respect to those who wrote the scripts.
They are quite robust.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message