fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on pull request #857: [WIP] MySQL v8(FINERACT-897)
Date Sun, 10 May 2020 13:39:47 GMT

vorburger commented on pull request #857:
URL: https://github.com/apache/fineract/pull/857#issuecomment-626329669


   > @awasum, @vorburger, @ptuomola is it for you?
   
   I would prefer to see the Flyway upgrade raised a separate PR with ref. to FINERACT-810.
Make FINERACT-810 a blocker for FINERACT-897 if that is the case (I'm assuming that you have
found that it is).
   
   Let us then clarify by updating both the title of FINERACT-897 and the commit comment in
this PR to more precisely express what exactly this is, and isn't... I think what we have
concluded in FINERACT-897 is that this now actually is NOT (anymore) a "Upgrade to mysql v8",
but... "make SQL and code work on both MySQL 5.7 as well as more recent versions such as v8"
- kind of wording?
   
   As for reviewing the (massive, wow, how did you do that, hats off!) SQL diff in this PR,
I'm not the most qualified - I'm hoping other parties interested in MySQL would chime in to
review this better than I could.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message