fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] [fineract] vorburger commented on pull request #869: retrofit from 1.6.1 to 1.9.0
Date Sun, 10 May 2020 12:49:15 GMT

vorburger commented on pull request #869:

   I've exceptionally "self merged" this PR, because technically I'm hereby reviewing and
approving a change made by Dependabot so with green Travis, we got 4-eyes on this - my 2 eyes,
and 1 each from Travis and Dependabot.. :rofl: 
   I've no idea what sort of test coverage we have for Fineract's use of,
or for what exactly we even used it where, but given that at least the build doesn't break,
let's go ahead. If any functionality is found to be broken, then this could always be reverted
again. (And a test written!)

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:

View raw message