fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on pull request #817: Step 1 of improving SchedulerJobHelper to be more reliable and prevent flaky tests (FINERACT-922)
Date Sat, 09 May 2020 15:19:47 GMT

vorburger commented on pull request #817:
URL: https://github.com/apache/fineract/pull/817#issuecomment-626191480


   I expect this PR will fail to fully pass integration tests, because it will highlight the
problem described in FINERACT-958. Not having the time to deal with FINERACT-958 myself, I'm
slightly torn how to proceed here... temporarily slapping an `@Ignore` on the (new) entire
`testTriggeringManualExecutionOfAllSchedulerJobs()` seems like such a shame. Should I just
hard-code skipping that one Job (`JobName`) which currently fails due to FINERACT-958, so
that we can merge this and at least get non-regression coverage for the other jobs, for now?
Inputs welcome.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message