fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] ptuomola commented on a change in pull request #807: FINERACT-730: Fixing bootRun and removing embedded Tomcat
Date Tue, 05 May 2020 19:40:35 GMT

ptuomola commented on a change in pull request #807:
URL: https://github.com/apache/fineract/pull/807#discussion_r420360097



##########
File path: Dockerfile
##########
@@ -37,18 +37,20 @@ RUN ./gradlew clean -x rat -x test war
 
 # =========================================
 
-FROM bitnami/tomcat:7.0.94 as fineract
+FROM bitnami/tomcat:latest as fineract

Review comment:
       Sorry. I did Commit Suggestion to accept it, but then looks like when I pushed a new
commit with the other changes you suggested (i.e. README.md etc) that got overwritten. I've
now pushed a new commit that hopefully addresses all of the comments you raised. Thanks again
for all the feedback! 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message