fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on pull request #798: add server.forward-headers-strategy=framework (FINERACT-914)
Date Sun, 03 May 2020 23:38:22 GMT

vorburger commented on pull request #798:
URL: https://github.com/apache/fineract/pull/798#issuecomment-623202643


   > How is server.forward-headers-strategy=framework different from server.forward-headers-strategy=native
   
   @awasum E.g. https://github.com/spring-projects/spring-boot/issues/18667 explains this
a bit, linking to https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.2-Release-Notes#deprecations-in-spring-boot-22,
note, quote:
   
   > (...) previously server.use-forward-headers=true would use the web server native support.
You can now achieve the same with server.forward-headers-strategy=native. Because each server
has a specific behavior, we now offer an alternative which relies on Spring’s ForwardedHeaderFilter:
server.forward-headers-strategy=framework. Developers should use the option that fits best
their use case.
   
   It seems to me that for us to use a Spring Framework Filter is better than to rely on Tomcat's
for this, because this means it will work the same if we ever switched e.g. from Tomcat to
Jetty, or if someone were to be crazy enough to deploy the Fineract WAR in something like
WAS or WLS... :smiling_imp: Also, `frameworks` actually does work and solves the problem...
:smile: see details in FINERACT-914.
   
   > Is the server.forward-headers-strategy=framework going to affect good old fashion
tomcat deployments?
   
   No, it should not. This thing basically just checks for certain HTTP Headers related to
SSL proxies and relevant for "serious" deployments, such as https://www.fineract.dev. In our
"traditional" deployment environments, such as Tomcat running locally, or inside a Docker
Container for Docker Compose, those HTTP Headers will not be present, and this PR should be
a NOOP for those.
   
   Thanks for the questions and doing a real review!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message