fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on pull request #738: GSIM and GLIM with test cases (FINERACT-603)
Date Sat, 02 May 2020 20:58:24 GMT

vorburger commented on pull request #738:
URL: https://github.com/apache/fineract/pull/738#issuecomment-623012346


   @rrpawar96 I've just looked this over (again), and from my (technical) side there is nothing
shocking here (anymore) that would prevent this from being merged. We now need others to do
more reviews here - notably @nikpawar89 looks like he has previously reviewed, and should
re-review this if you've incorporated his feedback. I'm now OK to merge this when we have
LGTM from him.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message