fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] maektwain commented on pull request #796: FINERACT-38
Date Sat, 02 May 2020 18:59:49 GMT

maektwain commented on pull request #796:
URL: https://github.com/apache/fineract/pull/796#issuecomment-622998974


   > I have done a quick technical review, and have some minor feedback.
   > 
   > Other than that, someone else should probably do a more functional review?
   Should I qualify as "other ", since I have done end to end functional review and testing.
Though we need some "meta-other" to kind of validate "other" (Waiting)
   > 
   > We could also just merge after e.g. 2 weeks "grace period" if nobody can a functional
review within 2 weeks after technical feedback is taken into account (we have done this before
for other functional enhancements).
   I think we should write some functional tests also (We could cover such scenario, then
we won't be much dependent on others to validate the functional test) then in the end only
manual testing is required?
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message