From commits-return-7992-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Wed Apr 15 08:20:11 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id AC7F318065C for ; Wed, 15 Apr 2020 10:20:10 +0200 (CEST) Received: (qmail 84815 invoked by uid 500); 15 Apr 2020 08:20:10 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 84788 invoked by uid 99); 15 Apr 2020 08:20:10 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Apr 2020 08:20:10 +0000 From: GitBox To: commits@fineract.apache.org Subject: [GitHub] [fineract] vorburger commented on issue #765: improve ClientSavingsIntegrationTest error reporting (FINERACT-852) Message-ID: <158693881005.7699.8390932535847579058.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Wed, 15 Apr 2020 08:20:10 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit vorburger commented on issue #765: improve ClientSavingsIntegrationTest error reporting (FINERACT-852) URL: https://github.com/apache/fineract/pull/765#issuecomment-613892600 @awasum how would you feel about already merging this one? Despite the failing build, which is what #764 would avoid... this change, contrary to #761 does NOT actually comment (deactivate) out either of those two test failing tests, but just attempts to make the error reporting from one of those test failures more clear, for future investigations. If LGTY would you be wiling to merge it even with the IT build failure? Risk seems minimal, to me. @thesmallstar @fynmanoj FYI ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services