fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] nikpawar89 commented on pull request #738: GSIM and GLIM with test cases (FINERACT-603)
Date Sun, 26 Apr 2020 18:02:31 GMT

nikpawar89 commented on pull request #738:
URL: https://github.com/apache/fineract/pull/738#issuecomment-619596297


   @rrpawar96  Besides changes suggested by @vorburger , I want you to address the previously
discussed points : remove extra white spaces and lines.  Once this is done make sure you run
the test cases and manually verify normal savings and loan application functionalities ( by
installing Community App).  If regression is fine, I would give a go ahead from me to merge
this PR. 
   
   Having said that, as a Phase two( or in this phase itself- if required by other members)
We have to add API documentation of this feature.
   
   Once this is done, I would request you to take up Front end support for this feature. Any
further bug fixes and enhancements can be addressed during this phase.
   
   We are splitting this work in phases just to avoid the hassles of rebasing the code from
time to time.
   
   @vorburger @awasum  let me know what you guys think about this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message