fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] xurror commented on pull request #778: Display git build info (FINERACT-883)
Date Sun, 26 Apr 2020 12:56:59 GMT

xurror commented on pull request #778:
URL: https://github.com/apache/fineract/pull/778#issuecomment-619545470


   > @xurror re. test failure, follow #782 to find [FINERACT-899](https://issues.apache.org/jira/browse/FINERACT-899)
and note #774, I think if you rebase this, that will disappear.
   > 
   > > Oh now this interesting. Seems .git directory cannot be found here since it is
a file which is automatically ignored
   > 
   > I don't think the `.git/` _is a file which is automatically ignored_, but I suspect
there are several situations where it's not present... this project certainly should still
build even if there is no `.git/` directory present. This could happen if someone builds from
the Release ZIP, and a few other situations I can imagine...
   > 
   > > I'm thinking to set the option failOnNoDotGitFound to false. @vorburger, @awasum
do you think we can go with that.
   > 
   > ... therefore something like that would probably be acceptable / good idea; see [FINERACT-911](https://issues.apache.org/jira/browse/FINERACT-911).
   > 
   > However I do not find an option `failOnNoDotGitFound` so I suspect this was a typo?
   
   Oops, typo. It's failOnNoGitDirectory.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message