fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #738: GSIM and GLIM with test cases (FINERACT-603)
Date Sun, 26 Apr 2020 10:50:48 GMT

vorburger commented on a change in pull request #738:
URL: https://github.com/apache/fineract/pull/738#discussion_r415279578



##########
File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java
##########
@@ -140,11 +140,11 @@
     @JoinColumn(name = "client_id", nullable = true)
     protected Client client;
 
-    @ManyToOne(optional = true)
+    @ManyToOne(optional = true, fetch=FetchType.LAZY)

Review comment:
       ```suggestion
       @ManyToOne(optional = true, fetch=FetchType.LAZY)  // see FINERACT-902
   ```

##########
File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java
##########
@@ -140,11 +140,11 @@
     @JoinColumn(name = "client_id", nullable = true)
     protected Client client;
 
-    @ManyToOne(optional = true)
+    @ManyToOne(optional = true, fetch=FetchType.LAZY)
     @JoinColumn(name = "group_id", nullable = true)
     protected Group group;
 
-    @ManyToOne
+    @ManyToOne(fetch=FetchType.LAZY)

Review comment:
       ```suggestion
       @ManyToOne(fetch=FetchType.LAZY) // see FINERACT-902
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message