fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #778: Display git build info (FINERACT-883)
Date Sun, 26 Apr 2020 10:06:06 GMT

vorburger commented on a change in pull request #778:
URL: https://github.com/apache/fineract/pull/778#discussion_r415269401



##########
File path: fineract-provider/build.gradle
##########
@@ -567,3 +576,11 @@ tasks.withType(SpotBugsTask) {
     reports.html.enabled = true
     reportLevel = "high"
 }
+
+gitProperties {
+    gitPropertiesResourceDir = "$buildDir/classes/java/main/resources"
+    dateFormat = "yyyy-MM-dd'T'HH:mmZ"
+    dateFormatTimeZone = "GMT"
+}
+
+generateGitProperties.outputs.upToDateWhen { false }

Review comment:
       May be it would be useful to document what this does inline? According to https://github.com/n0mer/gradle-git-properties/blob/master/README.md#other-usages:
   
   ```suggestion
   // make sure the generateGitProperties task always executes (even when git.properties is
not changed)
   generateGitProperties.outputs.upToDateWhen { false }
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message