fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #778: Display git build info (FINERACT-883)
Date Sun, 26 Apr 2020 09:50:42 GMT

vorburger commented on a change in pull request #778:
URL: https://github.com/apache/fineract/pull/778#discussion_r415268947



##########
File path: fineract-provider/build.gradle
##########
@@ -403,7 +404,14 @@ war {
 
 license {
     header rootProject.file('../APACHE_LICENSETEXT.md')
-    excludes(["**/*.html", "**/*.mustache", "**/package-info.java", "**/keystore.jks", "**/swagger-ui/**"])
+    excludes([

Review comment:
       Nice, but in a perfect world better raised in a very small separate PR. (I won't be
a PITA and still merge it if you leave this one here though.  But that RAT related change
really would be better to separate out.)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message