fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract-cn-anubis] aasaru commented on issue #11: FINCN-172
Date Mon, 20 Apr 2020 06:30:16 GMT

aasaru commented on issue #11:
URL: https://github.com/apache/fineract-cn-anubis/pull/11#issuecomment-616339182


   Hi @maektwain ! 
   Thanks for picking up this topic, it is very important and very valuable to community.
   
   I have created separate branches named "spring_boot_2" to each of the fineract-cn repository.
   Our CI and artifact building system is configured to build these artifacts completely separately.
   
   Please send your PR to this branch and (also check build.gradle newline characters):
   https://github.com/apache/fineract-cn-anubis/tree/spring_boot_2
   
   Then we can merge your PR and then anubis will be available as a dependency to bracnh spring_boot_2
of other fineract-cn repositories. Take a look to an example here:
   https://github.com/apache/fineract-cn-identity/blob/spring_boot_2/shared.gradle#L23
   
   Currently your PR is made to branch develop but if we merge this then everything else breaks
until you have managed to send PR-s to dependent repositories. This way (using separate branch
spring_boot_2) we can avoid such downtime.
   
   Thanks!
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message