fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] nikpawar89 commented on a change in pull request #738: GSIM and GLIM with test cases (FINERACT-603)
Date Sun, 19 Apr 2020 19:20:19 GMT
nikpawar89 commented on a change in pull request #738: GSIM and GLIM with test cases (FINERACT-603)
URL: https://github.com/apache/fineract/pull/738#discussion_r410972124
 
 

 ##########
 File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/data/CommandProcessingResultBuilder.java
 ##########
 @@ -106,6 +108,16 @@ public CommandProcessingResultBuilder withProductId(final Long productId)
{
         return this;
     }
 
+    public CommandProcessingResultBuilder withGsimId(final Long gsimId) {
 
 Review comment:
   This would have been painful during writing test cases and cause of many NPEs, I see gsimID
and glimID added in commandProcessingResult result but in commandWrapper, we are mapping glimID
and gsimID to entityID.
   This has made it asymmetric and doesn't go well with Test infra. If possible take these
new  instance variables out.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message