fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on issue #771: PRE_HOOK_TEST
Date Sat, 18 Apr 2020 15:58:44 GMT
vorburger commented on issue #771: PRE_HOOK_TEST
URL: https://github.com/apache/fineract/pull/771#issuecomment-615894413
 
 
   @maektwain  the (latest build of this) PR now fails due to https://issues.apache.org/jira/browse/FINERACT-899...
do you know how we could fix that? A contribution from you for that would be really really
really welcome!
   
   This PR also has a weird Commit history... 12 commits, of which many which are already
on develop now - I think something went wrong during your git rebase.. do you want to update
this to have 1 clean commit only?
   
   Once there is a clean diff, it will be easier to understand and review what this proposes.
Would this cause EVERY git commit locally to run full integration tests? I'm not entirely
sure yet if that is not too much. At least me I relatively often make small changes, and would
want to be able to commit them without having to run full integration tests locally. I'm assuming
that the problem you are trying to solve is the failing PRs on GitHub. But the reason for
that, IMHO, isn't really that people don't run tests locally - I think they (mostly) do. What's
really hurting us is are all the flaky test issues linked from https://issues.apache.org/jira/browse/FINERACT-850.
If you really want to help and have an impact, we would love help to sort that out...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message