fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] awasum commented on issue #719: FINERACT-809 - Upgrade rest-assured
Date Sun, 12 Apr 2020 19:35:27 GMT
awasum commented on issue #719: FINERACT-809 - Upgrade rest-assured
URL: https://github.com/apache/fineract/pull/719#issuecomment-612665311
 
 
   > > This is now passing? What did we fix?
   > 
   > I suspect that it's "flaky" - passes sometimes, but fails. The question is if with
the rest-assured upgrade Integration Tests fails a lot more often than they used to before
the upgrade, or if that was a total coincidence...
   > 
   > Given that we have it passing how, I would say why don't we merge this? If we suddenly
see ITs are failing a lot more often, we could always revert this.
   > 
   > > > @awasum, do you buy this idea?
   > > > Do it. Did u already add the fix?
   > 
   > Note [FINERACT-846](https://issues.apache.org/jira/browse/FINERACT-846) re. Java 11;
I would to do that separately than this PR.
   
   Seems @xurror  forced pushed this 3 hours ago: https://github.com/apache/fineract/pull/719/commits/627c7032565d31aa5eb6d75eac4f35a1c6310319,
why the thing passed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message