From commits-return-7667-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Sun Mar 15 08:36:27 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 48CEF180637 for ; Sun, 15 Mar 2020 09:36:27 +0100 (CET) Received: (qmail 82177 invoked by uid 500); 15 Mar 2020 08:36:26 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 82167 invoked by uid 99); 15 Mar 2020 08:36:26 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 15 Mar 2020 08:36:26 +0000 From: GitBox To: commits@fineract.apache.org Subject: [GitHub] [fineract] xurror commented on a change in pull request #722: Fineract-796 - Use Hikari instead of Tomcat Connection Pool Message-ID: <158426138646.5545.5460971317952702068.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Sun, 15 Mar 2020 08:36:26 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit xurror commented on a change in pull request #722: Fineract-796 - Use Hikari instead of Tomcat Connection Pool URL: https://github.com/apache/fineract/pull/722#discussion_r392652811 ########## File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/boot/db/DataSourceConfiguration.java ########## @@ -38,19 +39,19 @@ @Autowired JDBCDriverConfig config ; @Bean - public DataSourceProperties dataSourceProperties() { - return new DataSourceProperties(config.getDriverClassName(), config.getProtocol(), config.getSubProtocol(), config.getPort()); + public DataSourceProperties DataSourceProperties() { Review comment: Oh, little mistake on my behalf. It escaped my attention. Will patch that. Thanks ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services