From commits-return-7589-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Tue Mar 10 11:41:34 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9B53418069C for ; Tue, 10 Mar 2020 12:41:33 +0100 (CET) Received: (qmail 78981 invoked by uid 500); 10 Mar 2020 11:41:32 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 78818 invoked by uid 99); 10 Mar 2020 11:41:32 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Mar 2020 11:41:32 +0000 From: GitBox To: commits@fineract.apache.org Subject: [GitHub] [fineract] vorburger commented on a change in pull request #722: Fineract-796 - Use Hikari instead of Tomcat Connection Pool Message-ID: <158384049200.972.1100016844870577967.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Tue, 10 Mar 2020 11:41:32 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit vorburger commented on a change in pull request #722: Fineract-796 - Use Hikari instead of Tomcat Connection Pool URL: https://github.com/apache/fineract/pull/722#discussion_r390254495 ########## File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/boot/db/DataSourceProperties.java ########## @@ -31,8 +31,7 @@ * -Dfineract.datasource.port=3307. */ // NOT a @Component - we do not want this to picked up by component scan, only explicitly declared in DataSourceConfiguration (if that's active) -public class DataSourceProperties extends PoolProperties { - +public class DataSourceProperties extends HikariConfig { Review comment: If you manage to delete `DataSourceConfiguration.java` (above), then I suspect we can delete this entire class as well.. Or is there anything else left that uses this? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services