From commits-return-7588-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Tue Mar 10 11:41:34 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7C62018067C for ; Tue, 10 Mar 2020 12:41:33 +0100 (CET) Received: (qmail 78912 invoked by uid 500); 10 Mar 2020 11:41:32 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 78795 invoked by uid 99); 10 Mar 2020 11:41:32 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Mar 2020 11:41:32 +0000 From: GitBox To: commits@fineract.apache.org Subject: [GitHub] [fineract] vorburger commented on a change in pull request #722: Fineract-796 - Use Hikari instead of Tomcat Connection Pool Message-ID: <158384049192.956.17052908753576354437.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Tue, 10 Mar 2020 11:41:31 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit vorburger commented on a change in pull request #722: Fineract-796 - Use Hikari instead of Tomcat Connection Pool URL: https://github.com/apache/fineract/pull/722#discussion_r390240313 ########## File path: fineract-provider/src/main/resources/META-INF/spring/jdbc.properties ########## @@ -20,4 +20,9 @@ DRIVERCLASS_NAME:org.drizzle.jdbc.DrizzleDriver PROTOCOL:jdbc SUB_PROTOCOL:mysql:thin -PORT:3306 \ No newline at end of file +PORT:3306 + +fineract_tenants_driver:org.drizzle.jdbc.DrizzleDriver +fineract_tenants_url:jdbc:mysql:thin://localhost:3306/fineract_tenants +fineract_tenants_uid:root +fineract_tenants_pwd:mysql Review comment: FTR: Seeing this surprised me a little at first (especially given that there's no equivalent before; given that the (now deleted) `fineract-provider/src/test/resources/META-INF/context.xml` was scoped test only, but then I understood how this works. Given that the docker compose test passes proves that overriding these properties actually really is working, so all good. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services