From commits-return-7560-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Mon Mar 9 13:34:24 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id A8633180181 for ; Mon, 9 Mar 2020 14:34:23 +0100 (CET) Received: (qmail 52148 invoked by uid 500); 9 Mar 2020 13:34:23 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 52138 invoked by uid 99); 9 Mar 2020 13:34:22 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Mar 2020 13:34:22 +0000 From: GitBox To: commits@fineract.apache.org Subject: [GitHub] [fineract] thesmallstar edited a comment on issue #725: Fix audit trails filter (FINERACT-808) Message-ID: <158376086287.2813.18322959655753227919.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Mon, 09 Mar 2020 13:34:22 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit thesmallstar edited a comment on issue #725: Fix audit trails filter (FINERACT-808) URL: https://github.com/apache/fineract/pull/725#issuecomment-596526103 @vorburger It turns out everything is a valid column name as long as we use it between ` ` ` ` :P check this ![image](https://user-images.githubusercontent.com/42006277/76217325-3da2ee00-6238-11ea-99e8-ae40dce9ec83.png) For our convenience though, we can limit it to this form of regex [validtablename.]validcolumnname [ ] -> means optional, and valid table name and valid column name comes from: [here](https://stackoverflow.com/questions/4977898/check-for-valid-sql-column-name) Regex: ^[a-zA-Z_][a-zA-Z0-9_]*$ any suggestions? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services