From commits-return-7525-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Sun Mar 8 14:27:40 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3FB9C18067C for ; Sun, 8 Mar 2020 15:27:40 +0100 (CET) Received: (qmail 55392 invoked by uid 500); 8 Mar 2020 14:27:39 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 55363 invoked by uid 99); 8 Mar 2020 14:27:39 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 08 Mar 2020 14:27:39 +0000 From: GitBox To: commits@fineract.apache.org Subject: [GitHub] [fineract] vorburger commented on a change in pull request #723: FINERACT-808 FIXES: Some Action names do not filter audit trails Message-ID: <158367765924.16247.1293417932440200085.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Sun, 08 Mar 2020 14:27:39 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit vorburger commented on a change in pull request #723: FINERACT-808 FIXES: Some Action names do not filter audit trails URL: https://github.com/apache/fineract/pull/723#discussion_r389374375 ########## File path: fineract-provider/src/main/java/org/apache/fineract/commands/api/AuditsApiResource.java ########## @@ -165,7 +165,7 @@ private String getExtraCriteria(final String actionName, final String entityName String extraCriteria = ""; if (actionName != null) { - extraCriteria += " and aud.action_name = " + ApiParameterHelper.sqlEncodeString(actionName); + extraCriteria += " and aud.action_name = " + ApiParameterHelper.sqlEncodedStringForWhere(actionName); Review comment: I'm not sure this is a good idea, see longer comment in main Conversation. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services