fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract-cn-mobile] garvit984 opened a new pull request #82: Update CustomerProfileActivity.java
Date Tue, 10 Mar 2020 16:58:14 GMT
garvit984 opened a new pull request #82: Update CustomerProfileActivity.java
URL: https://github.com/apache/fineract-cn-mobile/pull/82
 
 
   Fixes #78 FIN-203
   
   Checking for Camera Permission instead of Write Permission in CustomerProfileActivity
   
   Click on "Customer" inside the drawer.
   Click on any item in the list of customers.
   Click on the profile picture (by default it's the Mifos Logo)
   Click on the "Share" option in the app bar.
   Supposing the permission to write to external storage is not given, it'll ask for permission.
When granted it should ideally call the "share image" method, but nothing happens. This is
because when the Permission is being granted, it's checking for "CAMERA" permission instead
of "WRITE_EXTERNAL_STORAGE" permission.
   It occurs when the permission is being granted initially and later, this error does not
occur.
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
    Apply the AndroidStyle.xml style template to your code in Android Studio.
   
    Run the unit tests with ./gradlew check to make sure you didn't break anything.
   
    If you have multiple commits please combine them into one commit by squashing them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message