fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] maektwain opened a new pull request #737: FINERACT-38
Date Wed, 18 Mar 2020 11:53:39 GMT
maektwain opened a new pull request #737: FINERACT-38
URL: https://github.com/apache/fineract/pull/737
 
 
   ## Description
   I was able to merge the source code which was done @Ippezrobert  on FINERACT-38 , I have
done some minimal testing as of now. 
   
   Have not written test as of now.
   
   ## Checklist
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [ Y] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/.
Ex: FINERACT-646 Pockets API.
   
   - [ Y ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions
have been followed.
   
   - [ N] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm
has been updated with details of any API changes.
   
   - [ N] Integration tests have been created/updated for verifying the changes made.
   
   - [ Y] All Integrations tests are passing with the new commits.
   
   - [ N] Submission is not a "code dump".  (Large changes can be made "in repository" via
a branch.  Ask on the list.)
   
   Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message