fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] thesmallstar opened a new pull request #729: FINERACT-808: fixes audit trails filter
Date Mon, 09 Mar 2020 17:28:23 GMT
thesmallstar opened a new pull request #729: FINERACT-808: fixes audit trails filter 
URL: https://github.com/apache/fineract/pull/729
 
 
   ## Description
   Please refer: #725 and #723 
   The current regex implemented for column name would accept the string of the form(highlighted
one is accepted):
   ![image](https://user-images.githubusercontent.com/42006277/76240260-ef521700-6258-11ea-8a48-d97d4772d49f.png)
   
   i.e optional(tablename.)columnname , where column name and table name must start with the
alphabet or _ and then may contain number,alplhabet, _ ,  -. 
   
   Functional testing is done: 
   ![image](https://user-images.githubusercontent.com/42006277/76240314-08f35e80-6259-11ea-812f-7fcd6b6f980a.png)
   
   
   
   ## Checklist
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/.
Ex: FINERACT-646 Pockets API.
   
   - [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions
have been followed.
   
   - [ ] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm
has been updated with details of any API changes.
   
   - [ ] Integration tests have been created/updated for verifying the changes made.
   
   - [ ] All Integrations tests are passing with the new commits.
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in repository" via
a branch.  Ask on the list.)
   
   Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message