fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract-cn-mobile] jawidMuhammadi commented on a change in pull request #95: fix: Added network change register
Date Sun, 22 Mar 2020 17:11:12 GMT
jawidMuhammadi commented on a change in pull request #95: fix: Added network change register
URL: https://github.com/apache/fineract-cn-mobile/pull/95#discussion_r396117678
 
 

 ##########
 File path: app/src/main/java/org/apache/fineract/ui/online/DashboardActivity.java
 ##########
 @@ -74,6 +76,8 @@ protected void onCreate(Bundle savedInstanceState) {
             StartSyncJob.scheduleItNow();
             preferencesHelper.setFetching(false);
         }
+
+        registerNetworkRegister();
 
 Review comment:
   Yeah, I totally agree with you. But you have registered the broadcast in Manifest file
too. If you think the dynamic registration is better then there is no need to register in
the Manifest file. Right now you are registering one receiver in two places.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message