fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] IOhacker commented on issue #734: SonarQube is add to do the analysis of Fineract code
Date Sun, 15 Mar 2020 14:52:43 GMT
IOhacker commented on issue #734: SonarQube is add to do the analysis of Fineract code
URL: https://github.com/apache/fineract/pull/734#issuecomment-599220621
 
 
   I want to add, "repositories" are duplicated I just have put jcenter and 
   mavencentral inside the same {} , also the java editor show the warning, 
   by the way and many others, seems that for every task inside de 
   build.gradle there are duplicates .
   
   You can find in the attached document (shared as a link) in the PR how 
   to add the variables in Travis, also it goes again
   
   
   https://docs.google.com/document/d/1kAoeJHxctVpNC_2b4J7o-jVALvCisf5U1yvi80Cq6uA/edit?usp=sharing
   
   
   El 15/03/20 a las 4:15, Michael Vorburger ⛑️ escribió:
   >
   > *@vorburger* commented on this pull request.
   >
   > Could you rebase and squash into a single commit?
   >
   > I've also provided some first review feedback.
   >
   > ------------------------------------------------------------------------
   >
   > In fineract-provider/build.gradle 
   > <https://github.com/apache/fineract/pull/734#discussion_r392659100>:
   >
   > > @@ -145,6 +147,7 @@ group = 'org.apache.fineract'
   >   buildDir = new File(rootProject.projectDir, "../build")
   >   repositories {
   >   	jcenter()
   > +    mavenCentral()
   >
   > Are you sure this is needed? jcentral is (should be..) a superset of 
   > mavenCentral, and already have anything that's on mavenCentral.
   >
   > ------------------------------------------------------------------------
   >
   > In .travis.yml 
   > <https://github.com/apache/fineract/pull/734#discussion_r392659231>:
   >
   > > @@ -61,5 +61,5 @@ script:
   >   # using "&&" instead of several "-" means that integrationTest does not
run if test fails,
   >   # and Docker test does not run if integration test fails, which makes PR failure
easier to understand.
   >   # @see https://docs.travis-ci.com/user/job-lifecycle/#customizing-the-build-phase
   > -  - ./gradlew --console=plain licenseMain licenseTest licenseIntegrationTest check
 &&  ./gradlew --console=plain integrationTest  &&  sudo service mysql stop
 &&  docker-compose build  &&  docker-compose up -d  &&  sleep 30s
 &&  http --verify=no --timeout 240 --check-status get https://localhost:8443/fineract-provider/actuator/health
   > +  - ./gradlew --console=plain licenseMain licenseTest licenseIntegrationTest check
 && ./gradlew --console=plain integrationTest && ./gradlew --console=plain
sonarqube -Dsonar.host.url=$SONAR_HOST_URL -Dsonar.organization=$SONAR_ORGANIZATION -Dsonar.projectKey=$SONAR_PROJECT_KEY
-Dsonar.login=$SONAR_TOKEN -Dsonar.verbose=true --stacktrace &&  sudo service mysql
stop  &&  docker-compose build  &&  docker-compose up -d  &&  sleep
30s  &&  http --verify=no --timeout 240 --check-status get https://localhost:8443/fineract-provider/actuator/health
   >
   > Where/how is SONAR_TOKEN etc. defined?
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub 
   > <https://github.com/apache/fineract/pull/734#pullrequestreview-374786120>, 
   > or unsubscribe 
   > <https://github.com/notifications/unsubscribe-auth/ALD2ZAXYVVSCHJ2CTTCUHVTRHSTFZANCNFSM4LKP6VXA>.
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message