fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #722: Fineract-796 - Use Hikari instead of Tomcat Connection Pool
Date Sun, 15 Mar 2020 10:20:24 GMT
vorburger commented on a change in pull request #722: Fineract-796 - Use Hikari instead of
Tomcat Connection Pool
URL: https://github.com/apache/fineract/pull/722#discussion_r392659704
 
 

 ##########
 File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/boot/db/DataSourceProperties.java
 ##########
 @@ -78,31 +77,23 @@ public DataSourceProperties(String driverClassName, String protocol,
String subP
      * .createNewDataSourceFor(FineractPlatformTenant)
      */
     protected void setDefaults() {
-        setInitialSize(3);
+        setMinimumIdle(3);
         // setMaxIdle(6); -- strange, why?
         // setMinIdle(3); -- JavaDoc says default is initialSize.. so shouldn't
         // be needed
-        if (getValidationQuery() == null) setValidationQuery("SELECT 1");
-        setTestOnBorrow(true);
-        setTestOnReturn(true);
-        setTestWhileIdle(true);
-        setTimeBetweenEvictionRunsMillis(30000);
-        setTimeBetweenEvictionRunsMillis(60000);
-        setLogAbandoned(true);
-        setSuspectTimeout(60);
-
-        setJdbcInterceptors("org.apache.tomcat.jdbc.pool.interceptor.ConnectionState;"
-                + "org.apache.tomcat.jdbc.pool.interceptor.StatementFinalizer;org.apache.tomcat.jdbc.pool.interceptor.SlowQueryReport");
 
 Review comment:
   No, just delete it, it's fine.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message