fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract-cn-mobile] jawidMuhammadi commented on a change in pull request #82: Update CustomerProfileActivity.java
Date Wed, 11 Mar 2020 16:11:39 GMT
jawidMuhammadi commented on a change in pull request #82: Update CustomerProfileActivity.java
URL: https://github.com/apache/fineract-cn-mobile/pull/82#discussion_r391088637
 
 

 ##########
 File path: app/src/main/java/org/apache/fineract/ui/online/customers/customerprofile/CustomerProfileActivity.java
 ##########
 @@ -164,6 +168,16 @@ public void onRequestPermissionsResult(int requestCode, @NonNull String[]
permis
                     Toaster.show(findViewById(android.R.id.content),
                             getString(R.string.permission_denied_write));
                 }
+            case ConstantKeys.PERMISSIONS_REQUEST_CAMERA: {switch (requestCode) {
+                case ConstantKeys.PERMISSION_REQUEST_WRITE_EXTERNAL_STORAGE: {
 
 Review comment:
   why we are using two switches? It is too complicated, even by that, as I see in both cases
we are doing the same thing. Instead, add only  `case ConstantKeys.PERMISSION_REQUEST_WRITE_EXTERNAL_STORAGE:`
before `case ConstantKeys.PERMISSIONS_REQUEST_CAMERA:` at line number 163 without adding `break`
after the first case. It will do the same work as your boilerplate codes are doing at line
numbers[171-180].

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message