fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #730: Added: SQL builder toString function
Date Tue, 10 Mar 2020 11:56:29 GMT
vorburger commented on a change in pull request #730: Added: SQL builder toString function
URL: https://github.com/apache/fineract/pull/730#discussion_r390261803
 
 

 ##########
 File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/utils/SQLBuilder.java
 ##########
 @@ -118,9 +121,34 @@ public String getSQLTemplate() {
     /*
      * Returns a String representation suitable for debugging and log output.
      * This is ONLY intended for debugging in logs, and NEVER for passing to a JDBC database.
+     */
     @Override
     public String toString() {
-        return "SQLBuilder{..."; // TODO implement this...
+        StringBuilder whereClause  = new StringBuilder();
+        ArrayList<String> modifiedArgs = new ArrayList<String>();
 
 Review comment:
   you can probably avoid creating this intermediate list? Just iterate and append to the
`StringBuilder`, no? Or perhaps I'm missing something here (quick review only; didn't read
the code in full details).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message