fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #722: Fineract-796 - Use Hikari instead of Tomcat Connection Pool
Date Tue, 10 Mar 2020 11:41:31 GMT
vorburger commented on a change in pull request #722: Fineract-796 - Use Hikari instead of
Tomcat Connection Pool
URL: https://github.com/apache/fineract/pull/722#discussion_r390240313
 
 

 ##########
 File path: fineract-provider/src/main/resources/META-INF/spring/jdbc.properties
 ##########
 @@ -20,4 +20,9 @@
 DRIVERCLASS_NAME:org.drizzle.jdbc.DrizzleDriver
 PROTOCOL:jdbc
 SUB_PROTOCOL:mysql:thin
-PORT:3306
\ No newline at end of file
+PORT:3306
+
+fineract_tenants_driver:org.drizzle.jdbc.DrizzleDriver
+fineract_tenants_url:jdbc:mysql:thin://localhost:3306/fineract_tenants
+fineract_tenants_uid:root
+fineract_tenants_pwd:mysql
 
 Review comment:
   FTR: Seeing this surprised me a little at first (especially given that there's no equivalent
before; given that the (now deleted) `fineract-provider/src/test/resources/META-INF/context.xml`
was scoped test only, but then I understood how this works. Given that the docker compose
test passes proves that overriding these properties actually really is working, so all good.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message