fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on issue #725: Fix audit trails filter (FINERACT-808)
Date Sun, 08 Mar 2020 17:31:46 GMT
vorburger commented on issue #725: Fix audit trails filter (FINERACT-808)
URL: https://github.com/apache/fineract/pull/725#issuecomment-596230270
 
 
   @thesmallstar I'm curious if (and how) you like this idea / approach... it's obviously
very much inspired by your work in #723!  If you do do like this, and are in favour of this
approach, then you can "LGTM" this PR, and perhaps would be willing to close your #723 ? 

   
   If you are further interested in the general topic of security and SQL injections, you
would be very very welcome to continue working in this area! Some ideas: 1. Implement the
`TODO` about the `toString()` in `SQLBuilder`[`Test`] (which I didn't have time for); 2. similarly
change `CenterReadPlatformServiceImpl`'s and `GroupReadPlatformServiceImpl`'s remaining use
of `ApiParameterHelper.sqlEncodeString` to this approach (and then delete `sqlEncodeString`),
and then more work as described in [FINERACT-854](https://issues.apache.org/jira/browse/FINERACT-854)...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message