fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] xurror commented on a change in pull request #722: Fineract-796 - Use Hikari instead of Tomcat Connection Pool
Date Sun, 08 Mar 2020 15:51:18 GMT
xurror commented on a change in pull request #722: Fineract-796 - Use Hikari instead of Tomcat
Connection Pool
URL: https://github.com/apache/fineract/pull/722#discussion_r389381558
 
 

 ##########
 File path: fineract-provider/src/test/resources/META-INF/context.xml
 ##########
 @@ -23,7 +23,6 @@
 
 <Context>
 	<Resource type="javax.sql.DataSource" name="jdbc/mifosplatform-tenants"
-		driverClassName="org.drizzle.jdbc.DrizzleDriver" url="jdbc:mysql:thin://localhost:3306/mifosplatform-tenants"
-		username="root" password="mysql" validationQuery="select 1" maxActive="10"
-		maxIdle="4" />
+		driverClassName="org.drizzle.jdbc.DrizzleDriver" jdbcUrl="jdbc:mysql:thin://localhost:3306/mifosplatform-tenants"
+		username="root" password="mysql" />
 
 Review comment:
   Seems to me that this resource file is used in build.gradle in operations such as "tomcatrunwar"
etc..., if you see what I mean.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message