fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #723: FINERACT-808 FIXES: Some Action names do not filter audit trails
Date Sun, 08 Mar 2020 14:27:39 GMT
vorburger commented on a change in pull request #723: FINERACT-808 FIXES: Some Action names
do not filter audit trails
URL: https://github.com/apache/fineract/pull/723#discussion_r389374375
 
 

 ##########
 File path: fineract-provider/src/main/java/org/apache/fineract/commands/api/AuditsApiResource.java
 ##########
 @@ -165,7 +165,7 @@ private String getExtraCriteria(final String actionName, final String
entityName
         String extraCriteria = "";
 
         if (actionName != null) {
-            extraCriteria += " and aud.action_name = " + ApiParameterHelper.sqlEncodeString(actionName);
+            extraCriteria += " and aud.action_name = " + ApiParameterHelper.sqlEncodedStringForWhere(actionName);
 
 Review comment:
   I'm not sure this is a good idea, see longer comment in main Conversation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message