fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on issue #710: FINERACT-807 - Use underscore instead of dash in tenants and default tenant database names
Date Sun, 08 Mar 2020 13:17:46 GMT
vorburger commented on issue #710: FINERACT-807  -  Use underscore instead of dash in tenants
and default tenant database names
URL: https://github.com/apache/fineract/pull/710#issuecomment-596204895
 
 
   LGTM! @xurror the only thing missing was that I hadn't noticed that you fixed this... :smile:
In the future when you fix up a PR (and ideally only after it actually passes the build..)
please "tag" (@vorburger) me with a short line such as "fixed and all good now (build passing),
could you re-review" kind of comment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message