fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on issue #722: Fineract-796 - Use Hikari instead of Tomcat Connection Pool
Date Sun, 08 Mar 2020 12:18:42 GMT
vorburger commented on issue #722: Fineract-796 - Use Hikari instead of Tomcat Connection Pool
URL: https://github.com/apache/fineract/pull/722#issuecomment-596199358
 
 
   Thanks for working on this! I'd love to get this ready to merge.
   
   So the Checkstyle violation seems to have been fixed, and as far as I can tell from the
latest log ├ČntegrationTest`passes here now. It's just failing in the final `docker-compose`
test, see `README.md` and last line in `.travis.yml` for how to launch that locally.  The
reason for that is related to the required changes review feedback I just posted - does it
make sense?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message